This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Add superfluous_disable_command SwiftLint exception
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2017 15:05
…avoid new warning in SwiftLint >0.22
djbe
reviewed
Oct 10, 2017
|
Will update the changes to reduce the diff and be compatible with 0.23.1, as not being able to disable that rule once for all was a SwiftLint bug. |
…mmand has been fixed in SwiftLint 0.23.1
|
@djbe still ok to merge even wth my last commit added to the mix? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftGen/SwiftGen#334
Avoids new warning in SwiftLint >0.22
Sadly, it seems that the only way for this exception to work is to repeat it on every
swiftlint:disableannotation. As mentioned in SwiftGen/SwiftGen#334, disabling it once at the beginning on the files doesn't seem to have any effect, it seems to only have effect to the rule we're currently disabling, hence it having to be repeated every time :-/I also had to break down some
// swiftlint:disablelines, disabling multiple rules at once, into multiple separate// swiftlint:disablelines now, since ironically those lines disable 4-5 rules at once began to be too long… triggering the "line too long" SwiftLint warning (I don't think this issue could have been more meta at that point ^^)